Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/resources/net_internals/capture_view.html

Issue 9585027: Limit the number of captured events held by about:net-internals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase off trunk again Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/capture_view.html
diff --git a/chrome/browser/resources/net_internals/capture_view.html b/chrome/browser/resources/net_internals/capture_view.html
index 818b3c969a4159a92a2783b2064da9928e85987f..2d384fad4e340e8009a573e410be2ac105bfc6e2 100644
--- a/chrome/browser/resources/net_internals/capture_view.html
+++ b/chrome/browser/resources/net_internals/capture_view.html
@@ -1,9 +1,18 @@
<div id=capture-view-tab-content class=content-box>
<h2>Capture options</h2>
+
+ <input id=capture-view-limit-checkbox type=checkbox />
+ <label for='capture-view-limit-checkbox'
+ title='If you capture all events for a long time, it is possible to exhaust memory and crash. Throwing out older data avoids this problem.'>
+ Discard old data under memory pressure.
+ </label>
+
+ <br/>
+
<input id=capture-view-byte-logging-checkbox type=checkbox />
- <label for='capture-view-byte-logging-checkbox'>
+ <label for='capture-view-byte-logging-checkbox'
+ title='This will result in huge log files, and can expose sensitive data'>
mmenke 2012/03/06 15:21:18 I don't think titles are sufficiently visible for
eroman 2012/03/06 17:14:14 Restored to italic. Here is what it looks like: ht
Include the actual bytes sent/received.
- <i>(This will result in huge log files, and can expose sensitive data)</i>
</label>
<ul>

Powered by Google App Engine
This is Rietveld 408576698