Add a source id to global NetLog entries.

net/socket/socket_test_util.cc

Index: net/socket/socket_test_util.cc
===================================================================
--- net/socket/socket_test_util.cc	(revision 126703)
+++ net/socket/socket_test_util.cc	(working copy)
@@ -636,7 +636,7 @@
 MockClientSocket::MockClientSocket(net::NetLog* net_log)
     : ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
       connected_(false),
-      net_log_(net::NetLog::Source(), net_log) {
+      net_log_(BoundNetLog::Make(net_log, net::NetLog::SOURCE_NONE)) {

[eroman, 2012/03/14 21:53:48]

How do you envision the javascript side of things dealing with this?

If clients bind a netlog for emitting global entries like this (which seems like
a legitimate use-case), then that means all the entries they emit will have the
same source ID (in other words, the javascript code can't rely on each having a
unique source ID).

Actually that seems like it should be fine, we would just pay attention to the
SOURCE_NONE.

[mmenke, 2012/03/14 22:25:23]

For emitting global entries, they should generally just use
NetLog::AddGlobalEntry, rather than binding a source, so each entry will get its
own unique source.

 }
 
 bool MockClientSocket::SetReceiveBufferSize(int32 size) {
@@ -1207,7 +1207,7 @@
       need_read_data_(true),
       pending_buf_(NULL),
       pending_buf_len_(0),
-      net_log_(net::NetLog::Source(), net_log),
+      net_log_(BoundNetLog::Make(net_log, net::NetLog::SOURCE_NONE)),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
   DCHECK(data_);
   data_->Reset();