Properly escape paths.

client/dom/scripts/systembase.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides base functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import os
 #import re
 import generator
 
+def EscapePath(path):

[podivilov, 2012/03/02 10:36:18]

Please rename to FixDartPathSeparators or something alike.

[antonm, 2012/03/02 10:41:53]

Done.

+  # The most robust way to emit path separators is to use / always.
+  return path.replace('\\', '/')
+
 class System(object):
   """A System generates all the files for one implementation.
 
   This is a base class for all the specific systems.
   The life-cycle of a System is:
   - construction (__init__)
   - (InterfaceGenerator | ProcessCallback)*  # for each IDL interface
   - GenerateLibraries
   - Finish
   """
@@ skipping 51 matching lines @@
     # Load template.
     template = self._templates.Load(lib_template)
     # Generate the .lib file.
     lib_file_contents = self._emitters.FileEmitter(lib_file_path)
 
     # Emit the list of #source directives.
     list_emitter = lib_file_contents.Emit(template, **template_args)
     lib_file_dir = os.path.dirname(lib_file_path)
     for path in sorted(file_paths):
       relpath = os.path.relpath(path, lib_file_dir)
-      list_emitter.Emit("#source('$PATH');\n", PATH=relpath)
+      list_emitter.Emit("#source('$PATH');\n", PATH=EscapePath(relpath))
 
 
   def _BaseDefines(self, interface):
     """Returns a set of names (strings) for members defined in a base class.
     """
     def WalkParentChain(interface):
       if interface.parents:
         # Only consider primary parent, secondary parents are not on the
         # implementation class inheritance chain.
         parent = interface.parents[0]
         if generator.IsDartCollectionType(parent.type.id):
           return
         if self._database.HasInterface(parent.type.id):
           parent_interface = self._database.GetInterface(parent.type.id)
           for attr in parent_interface.attributes:
             result.add(attr.id)
           for op in parent_interface.operations:
             result.add(op.id)
           WalkParentChain(parent_interface)
 
     result = set()
     WalkParentChain(interface)
     return result;