Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 9584044: Convert uses of int ms to TimeDelta in chrome/browser/printing. (Closed)

Created:
8 years, 9 months ago by Ted Vessenes
Modified:
8 years, 9 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert uses of int ms to TimeDelta in chrome/browser/printing. R=thestig@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted Vessenes
8 years, 9 months ago (2012-03-03 05:44:22 UTC) #1
Lei Zhang
lgtm
8 years, 9 months ago (2012-03-03 05:50:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9584044/1
8 years, 9 months ago (2012-03-03 05:50:49 UTC) #3
commit-bot: I haz the power
Presubmit check for 9584044-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-03 05:50:51 UTC) #4
Ted Vessenes
Apologies; sent this to the wrong reviewer. Can you review this?
8 years, 9 months ago (2012-03-03 06:25:08 UTC) #5
gene
On 2012/03/03 06:25:08, tedv wrote: > Apologies; sent this to the wrong reviewer. Can you ...
8 years, 9 months ago (2012-03-03 07:39:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9584044/1
8 years, 9 months ago (2012-03-03 15:42:35 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 17:17:11 UTC) #8
Change committed as 124866

Powered by Google App Engine
This is Rietveld 408576698