net/base/single_request_cert_verifier.cc - Issue 9584041: Create stubs for system certificate validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/single_request_cert_verifier.cc

Issue 9584041: Create stubs for system certificate validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Exclude CertVerifyProcNSS for non-NSS-only systems, for now Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/single_request_cert_verifier.cc

diff --git a/net/base/single_request_cert_verifier.cc b/net/base/single_request_cert_verifier.cc

index 60f9f1c8be0a87131e849cf58a4960c22d28e343..58017b492e519e470207402d7e3d358feffbcaab 100644

--- a/net/base/single_request_cert_verifier.cc

+++ b/net/base/single_request_cert_verifier.cc

@@ -35,10 +35,6 @@ int SingleRequestCertVerifier::Verify(X509Certificate* cert,

// Should not be already in use.

DCHECK(!cur_request_ && cur_request_callback_.is_null());

- // Do a synchronous verification.

- if (callback.is_null())

- return cert->Verify(hostname, flags, crl_set, verify_result);

CertVerifier::RequestHandle request = NULL;

// We need to be notified of completion before |callback| is called, so that