Chromium Code Reviews| Index: net/base/multi_threaded_cert_verifier.h |
| diff --git a/net/base/multi_threaded_cert_verifier.h b/net/base/multi_threaded_cert_verifier.h |
| index c8eca2e2cded6a73b64d1c463eadf5124ad25ebb..10c9421ccc74f24d2e7d14fd559496b987448080 100644 |
| --- a/net/base/multi_threaded_cert_verifier.h |
| +++ b/net/base/multi_threaded_cert_verifier.h |
| @@ -11,6 +11,7 @@ |
| #include "base/basictypes.h" |
| #include "base/gtest_prod_util.h" |
| +#include "base/memory/ref_counted.h" |
| #include "base/memory/scoped_ptr.h" |
| #include "base/threading/non_thread_safe.h" |
| #include "net/base/cert_database.h" |
| @@ -26,10 +27,11 @@ namespace net { |
| class CertVerifierJob; |
| class CertVerifierRequest; |
| class CertVerifierWorker; |
| +class CertVerifyProc; |
| // MultiThreadedCertVerifier is a CertVerifier implementation that runs |
| // synchronous CertVerifier implementations on worker threads. |
| -class NET_EXPORT MultiThreadedCertVerifier : |
| +class NET_EXPORT_PRIVATE MultiThreadedCertVerifier : |
| public CertVerifier, |
| NON_EXPORTED_BASE(public base::NonThreadSafe), |
| public CertDatabase::Observer { |
| @@ -56,6 +58,7 @@ class NET_EXPORT MultiThreadedCertVerifier : |
| friend class CertVerifierWorker; // Calls HandleResult. |
| friend class CertVerifierRequest; |
| friend class CertVerifierJob; |
| + friend class MultiThreadedCertVerifierTest; |
| FRIEND_TEST_ALL_PREFIXES(MultiThreadedCertVerifierTest, CacheHit); |
| FRIEND_TEST_ALL_PREFIXES(MultiThreadedCertVerifierTest, DifferentCACerts); |
| FRIEND_TEST_ALL_PREFIXES(MultiThreadedCertVerifierTest, InflightJoin); |
| @@ -121,6 +124,7 @@ class NET_EXPORT MultiThreadedCertVerifier : |
| uint64 cache_hits() const { return cache_hits_; } |
| uint64 requests() const { return requests_; } |
| uint64 inflight_joins() const { return inflight_joins_; } |
| + void SetCertVerifyProc(CertVerifyProc* verify_proc); |
|
wtc
2012/03/13 22:37:57
Nit: this probably can be named set_cert_verify_pr
Ryan Sleevi
2012/03/14 00:58:50
Since this wasn't inlined, I followed the MethodNa
|
| // cache_ maps from a request to a cached result. |
| typedef ExpiringCache<RequestParams, CachedResult> CertVerifierCache; |
| @@ -134,6 +138,8 @@ class NET_EXPORT MultiThreadedCertVerifier : |
| uint64 cache_hits_; |
| uint64 inflight_joins_; |
| + scoped_refptr<CertVerifyProc> verify_proc_; |
| + |
| DISALLOW_COPY_AND_ASSIGN(MultiThreadedCertVerifier); |
| }; |