Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: net/base/single_request_cert_verifier.cc

Issue 9584041: Create stubs for system certificate validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/multi_threaded_cert_verifier_unittest.cc ('k') | net/base/transport_security_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/single_request_cert_verifier.cc
diff --git a/net/base/single_request_cert_verifier.cc b/net/base/single_request_cert_verifier.cc
index 60f9f1c8be0a87131e849cf58a4960c22d28e343..58017b492e519e470207402d7e3d358feffbcaab 100644
--- a/net/base/single_request_cert_verifier.cc
+++ b/net/base/single_request_cert_verifier.cc
@@ -35,10 +35,6 @@ int SingleRequestCertVerifier::Verify(X509Certificate* cert,
// Should not be already in use.
DCHECK(!cur_request_ && cur_request_callback_.is_null());
- // Do a synchronous verification.
Ryan Sleevi 2012/03/03 05:01:50 I checked every user of SingleRequestCertVerifier,
wtc 2012/03/06 23:10:14 I guess we can replace this with a DCHECK? The co
- if (callback.is_null())
- return cert->Verify(hostname, flags, crl_set, verify_result);
-
CertVerifier::RequestHandle request = NULL;
// We need to be notified of completion before |callback| is called, so that
« no previous file with comments | « net/base/multi_threaded_cert_verifier_unittest.cc ('k') | net/base/transport_security_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698