Improve implementation of isInstanceOf in JSONSchemaValidator.

Improve implementation of isInstanceOf in JSONSchemaValidator.

This does not update the docs because they have gotten badly
out of date. I will update them separately.

BUG=116490
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124835

[Aaron Boodman, 2012-03-02 19:46:27]

+mpcomplete fyi

[arv (Not doing code reviews), 2012-03-02 19:58:28]

https://chromiumcodereview.appspot.com/9584021/diff/1/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/json_schema.js (right):

https://chromiumcodereview.appspot.com/9584021/diff/1/chrome/renderer/resourc...
chrome/renderer/resources/extensions/json_schema.js:283: if
(Object.prototype.toString.call(instance) !=
It seems a bit cleaner to get the substring here

Object.prototype.toString.call(instance).slice(8, -1) != schema.isInstanceOf

[Aaron Boodman, 2012-03-02 22:54:26]

Also removed a test that no longer can be implemented. I'm looking into an
alternate implementation, but it's not high priority.

https://chromiumcodereview.appspot.com/9584021/diff/1/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/json_schema.js (right):

https://chromiumcodereview.appspot.com/9584021/diff/1/chrome/renderer/resourc...
chrome/renderer/resources/extensions/json_schema.js:283: if
(Object.prototype.toString.call(instance) !=
On 2012/03/02 19:58:28, arv wrote:
> It seems a bit cleaner to get the substring here
> 
> Object.prototype.toString.call(instance).slice(8, -1) != schema.isInstanceOf

Disagree. I think the intention of the code is much clearer the way it is than
what you propose, and I dislike the magic number.

[arv (Not doing code reviews), 2012-03-02 23:07:35]

lgtm

[commit-bot: I haz the power, 2012-03-03 00:50:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/9584021/3003

[commit-bot: I haz the power, 2012-03-03 08:30:00]

Change committed as 124835

[arv (Not doing code reviews), 2012-03-05 19:13:07]

Sorry for adding more feedback to this. I thought a bit more about this over the
weekend.

http://codereview.chromium.org/9584021/diff/3003/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/json_schema.js (right):

http://codereview.chromium.org/9584021/diff/3003/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/json_schema.js:283: if
(Object.prototype.toString.call(instance) !=
Maybe we should have walked the prototype chain so that we could have used
Window in the API. Using "global" seems ugly.

function isInstanceOfClass(object , className) {
  if (!object)
    return false;
  if (Object.prototype.toString.call(instance) === "[object " + className + "]")
    return true;
  return isInstanceOfClass(Object.getPrototypeOf(object), className);
}

[Aaron Boodman, 2012-03-05 21:06:07]

http://codereview.chromium.org/9584021/diff/3003/chrome/renderer/resources/ex...
File chrome/renderer/resources/extensions/json_schema.js (right):

http://codereview.chromium.org/9584021/diff/3003/chrome/renderer/resources/ex...
chrome/renderer/resources/extensions/json_schema.js:283: if
(Object.prototype.toString.call(instance) !=
On 2012/03/05 19:13:07, arv wrote:
> Maybe we should have walked the prototype chain so that we could have used
> Window in the API. Using "global" seems ugly.
> 
> function isInstanceOfClass(object , className) {
>   if (!object)
>     return false;
>   if (Object.prototype.toString.call(instance) === "[object " + className +
"]")
>     return true;
>   return isInstanceOfClass(Object.getPrototypeOf(object), className);
> }

I agree the recursive search is cooler, but in this case, I actually think that
documenting the return type is "global" is more correct than "Window".

I'll send a review for the recursive search, but will leave the docs the same.