Issue 9584012: Clean up cookie pyauto tests to actually test what the comments say

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9584012: Clean up cookie pyauto tests to actually test what the comments say (Closed)

Created:
8 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 9 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up cookie pyauto tests to actually test what the comments say Also make it possible to run the test against other hosts by specifying the environment variables COOKIES_TEST_HOST BUG=none TEST=pyauto Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124738

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -31 lines)			Patch
	M	chrome/test/functional/cookies.py	View		7 chunks	+65 lines, -31 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

LGTM. Thanks for the fixes https://chromiumcodereview.appspot.com/9584012/diff/1/chrome/test/functional/cookies.py File chrome/test/functional/cookies.py (right): https://chromiumcodereview.appspot.com/9584012/diff/1/chrome/test/functional/cookies.py#newcode65 chrome/test/functional/cookies.py:65: self.RestartBrowser(clear_profile=False) Hmm.. I guess ...

8 years, 9 months ago (2012-03-02 19:23:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/9584012/1

8 years, 9 months ago (2012-03-02 19:27:36 UTC) #3

Change committed as 124738

Expand Messages | Collapse Messages