PyAuto tests derived from PolicyTestBase now clear the profile.

PyAuto tests derived from PolicyTestBase now clear the profile.

BUG=chromium-os:27227
TEST=Ran policy.py

Change-Id: Icecc03e9f19c7839f47ede0a4b5f5544ae0cee24


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124998

[Nirnimesh, 2012-03-03 01:24:15]

where do you clear the profile?
Doesn't setUp() already begin with a blank profile?

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/pyauto.py:3681: PyUITest.setUp(self)
why?

[frankf, 2012-03-03 01:54:13]

setUp() is supposed to clear the profile, but this doesn't work when session
manager is restarted previously.

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/pyauto.py:3681: PyUITest.setUp(self)
I don't want Logout() to call the derived class's setUp(). PolicyTestBase's
setUp() setups a test server and logs you back in. I haven't fully tested this
CL yet, so assumption may be wrong in other scenarios (e.g. chromeos_login)

On 2012/03/03 01:24:15, Nirnimesh wrote:
> why?

[dtu, 2012-03-03 02:14:40]

LGTM

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/policy_base.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/policy_base.py:292: pyauto.PyUITest.Logout(self)
Kind of surprised this wasn't there before, since it does Login in setUp().

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/pyauto.py:3681: PyUITest.setUp(self)
On 2012/03/03 01:24:15, Nirnimesh wrote:
> why?

The intent in Logout() and Signout() is to do only the ChromeOS-specific testing
channel setup, not the test-specific setup from when a test overrides setUp(). I
would prefer if the ChromeOS-specific stuff is pulled out to its own method to
make this distinction clearer, but this is okay too.

[Nirnimesh, 2012-03-03 02:22:01]

LGTM

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/policy_base.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/policy_base.py:290: self.StopHTTPServer(self._http_server)
While you're in this code, could you also move this line to be after line 294
below so that dectruction happens in the opposite order of construction.

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/pyauto.py:3681: PyUITest.setUp(self)
On 2012/03/03 02:14:41, Dave Tu wrote:
> On 2012/03/03 01:24:15, Nirnimesh wrote:
> > why?
> 
> The intent in Logout() and Signout() is to do only the ChromeOS-specific
testing
> channel setup, not the test-specific setup from when a test overrides setUp().
I
> would prefer if the ChromeOS-specific stuff is pulled out to its own method to
> make this distinction clearer, but this is okay too.

Makes sense.

[frankf, 2012-03-03 03:48:05]

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/policy_base.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/policy_base.py:290: self.StopHTTPServer(self._http_server)
On 2012/03/03 02:22:01, Nirnimesh wrote:
> While you're in this code, could you also move this line to be after line 294
> below so that dectruction happens in the opposite order of construction.

Done.

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/9583034/diff/1/chrome/test/pyautolib/p...
chrome/test/pyautolib/pyauto.py:3681: PyUITest.setUp(self)
Agree. Now we have setUp(), SetUp(), __SetUp()
:)

On 2012/03/03 02:14:41, Dave Tu wrote:
> On 2012/03/03 01:24:15, Nirnimesh wrote:
> > why?
> 
> The intent in Logout() and Signout() is to do only the ChromeOS-specific
testing
> channel setup, not the test-specific setup from when a test overrides setUp().
I
> would prefer if the ChromeOS-specific stuff is pulled out to its own method to
> make this distinction clearer, but this is okay too.

[commit-bot: I haz the power, 2012-03-05 19:08:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/9583034/5002

[commit-bot: I haz the power, 2012-03-05 21:07:44]

Change committed as 124998