Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 9583032: Aura: Fix gray line at top of toolbar with translucent frames (Closed)

Created:
8 years, 9 months ago by James Cook
Modified:
8 years, 9 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

Aura: Fix gray line at top of toolbar with translucent frames The toolbar background painting code was copying pixels out of the toolbar background image with the wrong vertical offset. I also moved the paint code into BrowserNonClientFrameViewAura so it can get the proper tabstrip vertical offset, and also because that's a more appropriate place for the logic. BUG=113075 TEST=visual, ensure no "step" in the gradient at the bottom of the active tab or the top of the toolbar, for both maximized and restored windows TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124836

Patch Set 1 #

Patch Set 2 : tweak popup appearance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -89 lines) Patch
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 2 chunks +0 lines, -86 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc View 1 5 chunks +61 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Dave, PTAL.
8 years, 9 months ago (2012-03-03 00:37:16 UTC) #1
DaveMoore
lgtm
8 years, 9 months ago (2012-03-03 00:47:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9583032/1004
8 years, 9 months ago (2012-03-03 01:09:22 UTC) #3
commit-bot: I haz the power
Presubmit check for 9583032-1004 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-03 01:09:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/9583032/1004
8 years, 9 months ago (2012-03-03 01:10:43 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 08:30:11 UTC) #6
Change committed as 124836

Powered by Google App Engine
This is Rietveld 408576698