gdata:: Add GDataFileSystem::GetFile().

gdata:: Add GDataFileSystem::GetFile().

This function is used to get files from the file system.
For now, it always download files from the cloud.
We should have the caching layer in-pace here.

Along the way, a mssing 'return' to Remove().
Change GetDocumentUrlFromPath() to GetGDataFileInfoFromPath,
and wrote a test for it.

BUG=chromium-os:27174
TEST=unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124857

[achuithb, 2012-03-02 23:39:38]

lgtm

[zel, 2012-03-02 23:44:04]

lgtm

https://chromiumcodereview.appspot.com/9583031/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/9583031/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.h:48: // TODO(zelidrag): Will
give better description when reviewing code.
i am ok with this descirption

https://chromiumcodereview.appspot.com/9583031/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system.h:52: // TODO(zelidrag): Will
give better description when reviewing code.
same here

https://chromiumcodereview.appspot.com/9583031/diff/1/chrome/browser/chromeos...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

https://chromiumcodereview.appspot.com/9583031/diff/1/chrome/browser/chromeos...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:442: //
TODO(satorux): Write a test once DocumentsService is mockable.
maybe remove this test for now and just leave the comment?

[satorux1, 2012-03-03 00:39:10]

http://codereview.chromium.org/9583031/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/9583031/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_file_system.h:48: // TODO(zelidrag): Will
give better description when reviewing code.
On 2012/03/02 23:44:04, zel wrote:
> i am ok with this descirption

Done.

http://codereview.chromium.org/9583031/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_file_system.h:52: // TODO(zelidrag): Will
give better description when reviewing code.
On 2012/03/02 23:44:04, zel wrote:
> same here

Done.

http://codereview.chromium.org/9583031/diff/1/chrome/browser/chromeos/gdata/g...
File chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc (right):

http://codereview.chromium.org/9583031/diff/1/chrome/browser/chromeos/gdata/g...
chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:442: //
TODO(satorux): Write a test once DocumentsService is mockable.
On 2012/03/02 23:44:04, zel wrote:
> maybe remove this test for now and just leave the comment?

Done.

[commit-bot: I haz the power, 2012-03-03 07:13:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/9583031/2003

[commit-bot: I haz the power, 2012-03-03 10:18:10]

Change committed as 124857