Issue 9583026: Prepare for a change in contract to WebViewClient::createView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9583026: Prepare for a change in contract to WebViewClient::createView. (Closed)

Created:
8 years, 9 months ago by Charlie Reis

Modified:
8 years, 9 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Prepare for a change in contract to WebViewClient::createView. No behavior change. BUG=69267 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124921

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -0 lines)			Patch
M	content/renderer/render_view_impl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Charlie Reis

Here's the CL to prepare for https://bugs.webkit.org/show_bug.cgi?id=80057. It just forwards calls to the old createView ...

8 years, 9 months ago (2012-03-02 23:41:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/9583026/1

8 years, 9 months ago (2012-03-05 02:08:00 UTC) #3

Change committed as 124921