Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9583022: Don't suppress HW compositing on the new file manager (chrome://files). (Closed)

Created:
8 years, 9 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 9 months ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Don't suppress HW compositing on the new file manager (chrome://files). BUG=chromium-os:26939 TEST=--allow-webui-compositing no longer needed to get HW-accelerated decode & render on ARM crosbook. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124756

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M content/browser/mock_content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ami GONE FROM CHROMIUM
jam: please review.
8 years, 9 months ago (2012-03-02 19:28:22 UTC) #1
jam
these urls are chrome specific, so they don't belong in content. see http://www.chromium.org/developers/content-module for more ...
8 years, 9 months ago (2012-03-02 19:30:46 UTC) #2
jamesr
logic change LGTM, but I defer to jam@ on the code organization/layering stuff
8 years, 9 months ago (2012-03-02 19:35:04 UTC) #3
Ami GONE FROM CHROMIUM
On 2012/03/02 19:30:46, John Abd-El-Malek wrote: > these urls are chrome specific, so they don't ...
8 years, 9 months ago (2012-03-02 20:28:18 UTC) #4
jam
lgtm
8 years, 9 months ago (2012-03-02 20:31:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/9583022/4002
8 years, 9 months ago (2012-03-02 20:33:03 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 22:52:35 UTC) #7
Change committed as 124756

Powered by Google App Engine
This is Rietveld 408576698