Disable rendering on up-scale.

Disable rendering on up-scale.

BUG=116138
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124868

[Wez, 2012-03-02 19:20:03]

Quick-fix for crashes during host resize.

[alexeypa (please no reviews), 2012-03-02 19:59:04]

LGTM for a few of nits.

This change regresses zoom levels > 100% comparing to the current functionality.
We will not display anything while now the keep updating the screen, even if the
mouse aim is wrong. I guess it should be fine as a temporary solution.

This can come up in dogfood, so we should call it out in the dogfood document.

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc
File remoting/base/decoder_vp8.cc (right):

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc#ne...
remoting/base/decoder_vp8.cc:130: return;
I guess we should make the same check in DecoderRowBased::RenderFrame().
RectangleUpdateDecoder::DoPaint() is not good, since technically we can have a
mixture of working and broken codecs.

http://codereview.chromium.org/9583020/diff/1/remoting/client/plugin/pepper_v...
File remoting/client/plugin/pepper_view.cc (right):

http://codereview.chromium.org/9583020/diff/1/remoting/client/plugin/pepper_v...
remoting/client/plugin/pepper_view.cc:131: const SkIRect& clip_area) {
nit: I know you didn't write this but... :-) this can fit one line.

[alexeypa (please no reviews), 2012-03-02 20:00:46]

On 2012/03/02 19:59:04, alexeypa wrote:
> LGTM for a few of nits.

Hm. I wonder how "for" ended up in that line.  :-/

[Sergey Ulanov, 2012-03-02 20:03:27]

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc
File remoting/base/decoder_vp8.cc (right):

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc#ne...
remoting/base/decoder_vp8.cc:130: return;
Need {} around this line (multi-line condition)

[Wez, 2012-03-02 21:54:15]

On 2012/03/02 19:59:04, alexeypa wrote:
> LGTM for a few of nits.
> 
> This change regresses zoom levels > 100% comparing to the current
functionality.
> We will not display anything while now the keep updating the screen, even if
the
> mouse aim is wrong. I guess it should be fine as a temporary solution.

I plan to follow-up with a workaround to support up-scaling, albeit less
optimized.  This CL is just a quick-fix to make sure M19 doesn't go out with a
crasher in it.

[Wez, 2012-03-02 22:15:31]

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc
File remoting/base/decoder_vp8.cc (right):

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc#ne...
remoting/base/decoder_vp8.cc:130: return;
On 2012/03/02 20:03:27, sergeyu wrote:
> Need {} around this line (multi-line condition)

Done.

http://codereview.chromium.org/9583020/diff/1/remoting/base/decoder_vp8.cc#ne...
remoting/base/decoder_vp8.cc:130: return;
On 2012/03/02 19:59:04, alexeypa wrote:
> I guess we should make the same check in DecoderRowBased::RenderFrame().
> RectangleUpdateDecoder::DoPaint() is not good, since technically we can have a
> mixture of working and broken codecs.

DecoderRowBased currently doesn't support scaling at all, so I wonder how it
behaves in those cases?

http://codereview.chromium.org/9583020/diff/1/remoting/client/plugin/pepper_v...
File remoting/client/plugin/pepper_view.cc (right):

http://codereview.chromium.org/9583020/diff/1/remoting/client/plugin/pepper_v...
remoting/client/plugin/pepper_view.cc:131: const SkIRect& clip_area) {
On 2012/03/02 19:59:04, alexeypa wrote:
> nit: I know you didn't write this but... :-) this can fit one line.

Done.

[commit-bot: I haz the power, 2012-03-02 22:15:56]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Jamie, 2012-03-02 22:17:01]

lgtm

[commit-bot: I haz the power, 2012-03-02 22:28:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/9583020/3002

[commit-bot: I haz the power, 2012-03-03 03:14:26]

Try job failure for 9583020-3002 (retry) on win_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "unit_tests, browser_tests, ui_tests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-03 16:35:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/9583020/3002

[commit-bot: I haz the power, 2012-03-03 18:12:28]

Change committed as 124868