Making GenericScopedHandle capable of handling handle types other than HANDLE.

chrome/service/cloud_print/print_system_win.cc

Index: chrome/service/cloud_print/print_system_win.cc
diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc
index 229f2794803684c0716edb9e477e5e8d3aaf6039..6b1d5df817e343ae2e1d7427f5ed48e4cdedc66f 100644
--- a/chrome/service/cloud_print/print_system_win.cc
+++ b/chrome/service/cloud_print/print_system_win.cc
@@ -35,9 +35,22 @@ namespace {
 
 class PrinterChangeHandleTraits {

[Vitaly Buka (NO REVIEWS), 2012/03/05 18:52:14]

: pubic HandleTraits

[alexeypa (please no reviews), 2012/03/05 18:56:58]

No, why? HandleTraits and PrinterChangeHandleTraits are unrelated. They both
happen to use HANDLE as the raw handle type but it does not make them related.

[brettw, 2012/03/05 18:58:44]

I would not necessarily expect that the traits classes derive from each other in
this type of situation, so I think the existing code is fine.

  public:
+  typedef HANDLE Handle;
+
   static bool CloseHandle(HANDLE handle) {
     return ::FindClosePrinterChangeNotification(handle) != FALSE;
   }
+
+  static bool IsHandleValid(HANDLE handle) {
+    return handle != NULL;
+  }
+
+  static HANDLE NullHandle() {
+    return NULL;
+  }
+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(PrinterChangeHandleTraits);
 };
 
 typedef base::win::GenericScopedHandle<PrinterChangeHandleTraits>