Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9582044: Convert uses of int ms to TimeDelta in dbus. (Closed)

Created:
8 years, 9 months ago by Ted Vessenes
Modified:
8 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert uses of int ms to TimeDelta in dbus. R=satorux@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126055

Patch Set 1 #

Patch Set 2 : Fix mock PostDelayedTask function interface. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M dbus/bus.h View 1 chunk +1 line, -1 line 0 comments Download
M dbus/bus.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/mock_bus.h View 1 1 chunk +1 line, -1 line 0 comments Download
M dbus/test_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Ted Vessenes
8 years, 9 months ago (2012-03-03 05:44:00 UTC) #1
Ted Vessenes
Did you need me to find another reviewer for this? I looked at the code ...
8 years, 9 months ago (2012-03-08 19:20:31 UTC) #2
satorux1
LGTM. Thank you for doing this. Sorry for the belated response. It was just an ...
8 years, 9 months ago (2012-03-08 20:41:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9582044/1
8 years, 9 months ago (2012-03-08 20:46:07 UTC) #4
Ted Vessenes
Not a problem. I was juggling over a dozen different CLs on my side, so ...
8 years, 9 months ago (2012-03-08 20:46:20 UTC) #5
commit-bot: I haz the power
Try job failure for 9582044-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-08 21:23:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9582044/1
8 years, 9 months ago (2012-03-09 03:41:38 UTC) #7
commit-bot: I haz the power
Try job failure for 9582044-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-09 04:10:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9582044/11001
8 years, 9 months ago (2012-03-10 21:07:44 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-11 01:12:21 UTC) #10 
Change committed as 126055

Powered by Google App Engine
This is Rietveld 408576698