Issue 9582031: Don't crash in ~HostNPScriptObject() when the object wasn't initialized.

Issue 9582031: Don't crash in ~HostNPScriptObject() when the object wasn't initialized. (Closed)

Created:
8 years, 9 months ago by Sergey Ulanov

Modified:
8 years, 9 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't crash in ~HostNPScriptObject() when the object wasn't initialized. BUG=112656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125079

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove Stop() #

Patch Set 3 : - #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -63 lines)			Patch
M	remoting/host/chromoting_host_context.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	remoting/host/chromoting_host_context.cc	View	1	1 chunk	+3 lines, -13 lines	0 comments	Download
M	remoting/host/chromoting_host_context_unittest.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	remoting/host/host_mock_objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/plugin/host_script_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View		16 chunks	+41 lines, -35 lines	0 comments	Download
M	remoting/jingle_glue/jingle_thread.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/jingle_thread.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM, but I'm a little concerned about the risk of the host context being torn ...

8 years, 9 months ago (2012-03-02 22:59:48 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/9582031/diff/1/remoting/host/chromoting_host_context.h File remoting/host/chromoting_host_context.h (right): http://codereview.chromium.org/9582031/diff/1/remoting/host/chromoting_host_context.h#newcode30 remoting/host/chromoting_host_context.h:30: virtual void Stop(); On 2012/03/02 22:59:48, Wez wrote: > ...

8 years, 9 months ago (2012-03-05 06:53:35 UTC) #3