Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 9582022: Make NTP other sessions menu off disabled by default. (Closed)

Created:
8 years, 9 months ago by Patrick Dubroy
Modified:
8 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Make NTP other sessions menu off disabled by default. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124769

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Patrick Dubroy
8 years, 9 months ago (2012-03-02 20:00:38 UTC) #1
Evan Stade
http://codereview.chromium.org/9582022/diff/1/chrome/browser/resources/ntp4/new_tab.html File chrome/browser/resources/ntp4/new_tab.html (left): http://codereview.chromium.org/9582022/diff/1/chrome/browser/resources/ntp4/new_tab.html#oldcode113 chrome/browser/resources/ntp4/new_tab.html:113: <div id="vertical-separator"></div> I think we do want this in ...
8 years, 9 months ago (2012-03-02 20:02:38 UTC) #2
Patrick Dubroy
I pulled it out for now to prevent having two items with the same id. ...
8 years, 9 months ago (2012-03-02 20:06:29 UTC) #3
Dan Beam
On 2012/03/02 20:06:29, dubroy wrote: > I pulled it out for now to prevent having ...
8 years, 9 months ago (2012-03-02 20:26:12 UTC) #4
Patrick Dubroy
On 2012/03/02 20:26:12, Dan Beam wrote: > On 2012/03/02 20:06:29, dubroy wrote: > > I ...
8 years, 9 months ago (2012-03-02 20:33:36 UTC) #5
Evan Stade
lgtm
8 years, 9 months ago (2012-03-02 21:13:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/9582022/1
8 years, 9 months ago (2012-03-02 21:24:47 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 23:34:21 UTC) #8
Change committed as 124769

Powered by Google App Engine
This is Rietveld 408576698