Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2711)

Unified Diff: chrome/browser/tab_render_watcher.h

Issue 9582012: TabFirstRenderWatcher -> TabRenderWatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_first_render_watcher_browsertest.cc ('k') | chrome/browser/tab_render_watcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_render_watcher.h
diff --git a/chrome/browser/tab_first_render_watcher.h b/chrome/browser/tab_render_watcher.h
similarity index 61%
rename from chrome/browser/tab_first_render_watcher.h
rename to chrome/browser/tab_render_watcher.h
index f73c4fb13947eb69e5eb65ed94d0dc862dd50ae7..72b99ca57f3d381da23c1cb3ac9a4897e2912d76 100644
--- a/chrome/browser/tab_first_render_watcher.h
+++ b/chrome/browser/tab_render_watcher.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_TAB_FIRST_RENDER_WATCHER_H_
-#define CHROME_BROWSER_TAB_FIRST_RENDER_WATCHER_H_
+#ifndef CHROME_BROWSER_TAB_RENDER_WATCHER_H_
+#define CHROME_BROWSER_TAB_RENDER_WATCHER_H_
#pragma once
#include "base/compiler_specific.h"
@@ -17,16 +17,16 @@ class WebContents;
}
// This class watches given TabContent's loading and rendering state change.
-class TabFirstRenderWatcher : public content::NotificationObserver {
+class TabRenderWatcher : public content::NotificationObserver {
public:
class Delegate {
public:
virtual void OnRenderHostCreated(RenderViewHost* host) = 0;
virtual void OnTabMainFrameLoaded() = 0;
- virtual void OnTabMainFrameFirstRender() = 0;
+ virtual void OnTabMainFrameRender() = 0;
};
- TabFirstRenderWatcher(content::WebContents* tab, Delegate* delegate);
+ TabRenderWatcher(content::WebContents* tab, Delegate* delegate);
private:
// Overridden from content::NotificationObserver
@@ -34,12 +34,8 @@ class TabFirstRenderWatcher : public content::NotificationObserver {
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- enum State {
- NONE,
- LOADED, // Renderer loaded the page.
- FIRST_PAINT, // 1st paint event after the page is loaded.
- };
- State state_;
+ // Has the renderer loaded the page yet?
+ bool loaded_;
// WebContents that this class watches.
content::WebContents* web_contents_;
@@ -49,7 +45,7 @@ class TabFirstRenderWatcher : public content::NotificationObserver {
content::NotificationRegistrar registrar_;
- DISALLOW_COPY_AND_ASSIGN(TabFirstRenderWatcher);
+ DISALLOW_COPY_AND_ASSIGN(TabRenderWatcher);
};
-#endif // CHROME_BROWSER_TAB_FIRST_RENDER_WATCHER_H_
+#endif // CHROME_BROWSER_TAB_RENDER_WATCHER_H_
« no previous file with comments | « chrome/browser/tab_first_render_watcher_browsertest.cc ('k') | chrome/browser/tab_render_watcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698