Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Unified Diff: chrome/browser/tab_render_watcher.cc

Issue 9582012: TabFirstRenderWatcher -> TabRenderWatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_render_watcher.h ('k') | chrome/browser/tab_render_watcher_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_render_watcher.cc
diff --git a/chrome/browser/tab_first_render_watcher.cc b/chrome/browser/tab_render_watcher.cc
similarity index 69%
rename from chrome/browser/tab_first_render_watcher.cc
rename to chrome/browser/tab_render_watcher.cc
index 69de9cf5d34c1c1406329eb2a3083e66d04ff6a4..4edb5ad6d4950fb4f96fbfedbea199fc875a9b3b 100644
--- a/chrome/browser/tab_first_render_watcher.cc
+++ b/chrome/browser/tab_render_watcher.cc
@@ -1,8 +1,8 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/tab_first_render_watcher.h"
+#include "chrome/browser/tab_render_watcher.h"
#include "content/browser/renderer_host/render_widget_host.h"
#include "content/browser/renderer_host/render_view_host.h"
@@ -13,9 +13,8 @@
using content::WebContents;
-TabFirstRenderWatcher::TabFirstRenderWatcher(WebContents* tab,
- Delegate* delegate)
- : state_(NONE),
+TabRenderWatcher::TabRenderWatcher(WebContents* tab, Delegate* delegate)
+ : loaded_(false),
web_contents_(tab),
delegate_(delegate) {
registrar_.Add(this,
@@ -26,9 +25,9 @@ TabFirstRenderWatcher::TabFirstRenderWatcher(WebContents* tab,
content::Source<WebContents>(web_contents_));
}
-void TabFirstRenderWatcher::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
+void TabRenderWatcher::Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) {
switch (type) {
case content::NOTIFICATION_RENDER_VIEW_HOST_CREATED_FOR_TAB: {
RenderWidgetHost* rwh = content::Details<RenderWidgetHost>(details).ptr();
@@ -40,18 +39,16 @@ void TabFirstRenderWatcher::Observe(int type,
break;
}
case content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME:
- if (state_ == NONE) {
- state_ = LOADED;
+ if (!loaded_) {
+ loaded_ = true;
delegate_->OnTabMainFrameLoaded();
}
break;
case content::NOTIFICATION_RENDER_WIDGET_HOST_DID_PAINT:
- if (state_ == LOADED) {
- state_ = FIRST_PAINT;
- delegate_->OnTabMainFrameFirstRender();
- }
+ if (loaded_)
+ delegate_->OnTabMainFrameRender();
break;
default:
- NOTREACHED() << "unknown type" << type;
+ NOTREACHED() << "Unknown notification " << type;
}
}
« no previous file with comments | « chrome/browser/tab_render_watcher.h ('k') | chrome/browser/tab_render_watcher_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698