Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 9582012: TabFirstRenderWatcher -> TabRenderWatcher. (Closed)

Created:
8 years, 9 months ago by Daniel Erat
Modified:
8 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

TabFirstRenderWatcher -> TabRenderWatcher. Page content often isn't completely loaded or laid out when the tab is first rendered. This makes the class additionally notify about subsequent renders so the delegate can hold off until it sees one after it's e.g. received notification via a WebUI message that the page is truly ready. BUG=chromium-os:26210 TEST=manual; also un-disabled the tests and checked that they still pass TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -263 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/tab_first_render_watcher.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/tab_first_render_watcher.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/tab_first_render_watcher_browsertest.cc View 1 chunk +0 lines, -88 lines 0 comments Download
A + chrome/browser/tab_render_watcher.h View 4 chunks +10 lines, -14 lines 0 comments Download
A + chrome/browser/tab_render_watcher.cc View 4 chunks +12 lines, -15 lines 0 comments Download
A + chrome/browser/tab_render_watcher_browsertest.cc View 5 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Erat
8 years, 9 months ago (2012-03-02 17:48:14 UTC) #1
xiyuan
LGTM I see what you mean now. :)
8 years, 9 months ago (2012-03-02 17:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9582012/1
8 years, 9 months ago (2012-03-02 21:02:29 UTC) #3
commit-bot: I haz the power
Presubmit check for 9582012-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-02 21:02:38 UTC) #4
Daniel Erat
TBR ben for chrome/browser/ui.
8 years, 9 months ago (2012-03-02 21:09:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/9582012/1
8 years, 9 months ago (2012-03-02 21:09:57 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-02 23:22:40 UTC) #7
Change committed as 124765

Powered by Google App Engine
This is Rietveld 408576698