Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 9582002: Order content::URLFetcher test code correctly (Closed)

Created:
8 years, 9 months ago by hashimoto
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Order content::URLFetcher test code correctly Sort all code in 'class declarations' -> 'method definitions' -> 'test code' order. Add missing OVERRIDEs BUG=None TEST=content_unittests --gtest_filter="URLFetcher*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124849

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add missing OVERRIDEs #

Patch Set 3 : Rebased onto ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -102 lines) Patch
M content/common/net/url_fetcher_impl_unittest.cc View 1 2 16 chunks +109 lines, -102 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
http://codereview.chromium.org/9582002/diff/1/content/common/net/url_fetcher_impl_unittest.cc File content/common/net/url_fetcher_impl_unittest.cc (right): http://codereview.chromium.org/9582002/diff/1/content/common/net/url_fetcher_impl_unittest.cc#newcode794 content/common/net/url_fetcher_impl_unittest.cc:794: // new_backoff = 2.0 * old_backoff + 0 fixed ...
8 years, 9 months ago (2012-03-02 10:26:42 UTC) #1
willchan no longer on Chromium
lgtm
8 years, 9 months ago (2012-03-02 19:47:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9582002/3001
8 years, 9 months ago (2012-03-03 02:53:57 UTC) #3
commit-bot: I haz the power
Can't apply patch for file content/common/net/url_fetcher_impl_unittest.cc. While running patch -p1 --forward --force; patching file content/common/net/url_fetcher_impl_unittest.cc ...
8 years, 9 months ago (2012-03-03 02:53:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9582002/5001
8 years, 9 months ago (2012-03-03 05:13:22 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 08:55:53 UTC) #6
Change committed as 124849

Powered by Google App Engine
This is Rietveld 408576698