Issue 9581026: Don't set ion=1 for hidden Instant modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9581026: Don't set ion=1 for hidden Instant modes. (Closed)

Created:
8 years, 9 months ago by sreeram

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't set ion=1 for hidden Instant modes. Setting ion=1 overrides google.com preferences, which can be a surprise. Visible Instant is not such a surprise, since the user can actually see the previews and thus associate it with Chrome Instant. BUG=105390 TEST=Start with --instant-field-trial=hidden and observe that the Instant homepage requests don't have ion=1. Turn off Google Instant (using google.com/preferences) and observe that Google Instant remains turned off on an omnibox-initiated search. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124850

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -4 lines)			Patch
M	chrome/browser/search_engines/search_terms_data.h	View	3 chunks	+14 lines, -2 lines	0 comments	Download
M	chrome/browser/search_engines/search_terms_data.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_prepopulate_data.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/9581026/1

8 years, 9 months ago (2012-03-03 05:26:02 UTC) #3

Change committed as 124850

Expand Messages | Collapse Messages