Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9581021: [refactor] Split up SourceTracker into SourceTracker + EventsTracker. (Closed)

Created:
8 years, 9 months ago by eroman
Modified:
8 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, eroman, arv (Not doing code reviews), mmenke
Visibility:
Public.

Description

[refactor] Split up SourceTracker into SourceTracker + EventsTracker. This is in preparation for adding some extra functionality at the EventsTracker layer (max events throttling). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124847

Patch Set 1 #

Total comments: 2

Patch Set 2 : update based on mmenke comments #

Messages

Total messages: 8 (0 generated)
eroman
8 years, 9 months ago (2012-03-02 22:01:44 UTC) #1
mmenke
LGTM https://chromiumcodereview.appspot.com/9581021/diff/1/chrome/browser/resources/net_internals/events_tracker.js File chrome/browser/resources/net_internals/events_tracker.js (right): https://chromiumcodereview.appspot.com/9581021/diff/1/chrome/browser/resources/net_internals/events_tracker.js#newcode40 chrome/browser/resources/net_internals/events_tracker.js:40: * Called when all log events have been ...
8 years, 9 months ago (2012-03-02 22:12:36 UTC) #2
eroman
https://chromiumcodereview.appspot.com/9581021/diff/1/chrome/browser/resources/net_internals/events_tracker.js File chrome/browser/resources/net_internals/events_tracker.js (right): https://chromiumcodereview.appspot.com/9581021/diff/1/chrome/browser/resources/net_internals/events_tracker.js#newcode40 chrome/browser/resources/net_internals/events_tracker.js:40: * Called when all log events have been deleted. ...
8 years, 9 months ago (2012-03-02 22:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/9581021/4001
8 years, 9 months ago (2012-03-02 22:20:16 UTC) #4
commit-bot: I haz the power
Try job failure for 9581021-4001 (retry) on win_rel for step "ui_tests". It's a second try, ...
8 years, 9 months ago (2012-03-03 02:39:25 UTC) #5
eroman
Those failures look bogus. Given it passed on all the other bots will commit manually.
8 years, 9 months ago (2012-03-03 02:41:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/9581021/4001
8 years, 9 months ago (2012-03-03 03:42:27 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 08:51:58 UTC) #8 
Change committed as 124847

Powered by Google App Engine
This is Rietveld 408576698