Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9581015: Include the headers from the libjingle overrides. (Closed)

Created:
8 years, 9 months ago by Ronghua Wu (Left Chromium)
Modified:
8 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
https://src.chromium.org/svn/trunk/src/
Visibility:
Public.

Description

Include the headers from the libjingle overrides. BUG=116567 TEST=apprtc.appspot.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124834

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M remoting/jingle_glue/xmpp_socket_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/message_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/rtp_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ronghua Wu (Left Chromium)
8 years, 9 months ago (2012-03-02 18:45:24 UTC) #1
Sergey Ulanov
LGTM. Thanks for fixing it.
8 years, 9 months ago (2012-03-02 18:48:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9581015/1
8 years, 9 months ago (2012-03-02 19:35:26 UTC) #3
commit-bot: I haz the power
Try job failure for 9581015-1 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 9 months ago (2012-03-02 20:56:26 UTC) #4
Ronghua Wu (Left Chromium)
Fix check_deps broken.
8 years, 9 months ago (2012-03-02 22:03:23 UTC) #5
Sergey Ulanov
On 2012/03/02 22:03:23, Ronghua Wu wrote: > Fix check_deps broken. still lgtm
8 years, 9 months ago (2012-03-02 22:08:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/9581015/3004
8 years, 9 months ago (2012-03-02 22:09:59 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 08:29:49 UTC) #8 
Change committed as 124834

Powered by Google App Engine
This is Rietveld 408576698