Issue 9580034: [polish] Make link targets on about:net-internals open in new window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9580034: [polish] Make link targets on about:net-internals open in new window. (Closed)

Created:
8 years, 9 months ago by eroman

Modified:
8 years, 9 months ago

Reviewers:
mmenke

CC:
chromium-reviews, eroman, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[polish] Make link targets on about:net-internals open in new window. This is a good idea since otherwise clicking URL can navigate you away from the page, and lose your capture data. Also fixed a CSS class naming to match our style better. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124889

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	chrome/browser/resources/net_internals/dns_view.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/hsts_view.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/http_cache_view.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/http_throttling_view.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/net_internals/proxy_view.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/net_internals/sockets_view.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/9580034/3001

8 years, 9 months ago (2012-03-04 04:53:35 UTC) #3

Change committed as 124889

Expand Messages | Collapse Messages