Issue 9580030: Inform webkit when PPAPI plugin contents are opaque.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9580030: Inform webkit when PPAPI plugin contents are opaque. (Closed)

Created:
8 years, 9 months ago by jbauman

Modified:
8 years, 9 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Inform webkit when PPAPI plugin contents are opaque. Most plugins want to be opaque, and notifying webkit of that will allow it to avoid rendering tiles behind the plugin and doing alpha blending. BUG=116205 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125100

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix is_opaque #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -6 lines)			Patch
M	content/renderer/pepper/pepper_platform_context_3d_impl.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d_impl.cc	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	5 chunks	+8 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_3d_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

LGTM+nit http://codereview.chromium.org/9580030/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.h File webkit/plugins/ppapi/ppapi_plugin_instance.h (right): http://codereview.chromium.org/9580030/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.h#newcode442 webkit/plugins/ppapi/ppapi_plugin_instance.h:442: void setBackingTextureId(unsigned int id, bool isOpaque); style nit: ...

8 years, 9 months ago (2012-03-06 01:40:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/9580030/10001

8 years, 9 months ago (2012-03-06 01:48:22 UTC) #3

Change committed as 125100

Expand Messages | Collapse Messages