Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 9580027: [Sync] Add unit tests for ChromeEncryptor (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing)
Visibility:
Public.

Description

[Sync] Add unit tests for ChromeEncryptor BUG=116607 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124892

Patch Set 1 #

Patch Set 2 : Fix unittests on OS X #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A chrome/browser/sync/glue/chrome_encryptor_unittest.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
akalin
+tim for review
8 years, 9 months ago (2012-03-02 22:05:25 UTC) #1
akalin
On 2012/03/02 22:05:25, akalin wrote: > +tim for review I think I have to do ...
8 years, 9 months ago (2012-03-02 22:39:28 UTC) #2
tim (not reviewing)
LGTM
8 years, 9 months ago (2012-03-04 00:16:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9580027/7001
8 years, 9 months ago (2012-03-04 07:56:20 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-04 09:28:55 UTC) #5
Change committed as 124892

Powered by Google App Engine
This is Rietveld 408576698