ash/desktop_background/desktop_background_resources.h - Issue 9580023: Enable user change background image in settings page in Aura build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/desktop_background/desktop_background_resources.h

Issue 9580023: Enable user change background image in settings page in Aura build. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Address review Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« ash/desktop_background/desktop_background_controller.h ('K') | « ash/desktop_background/desktop_background_controller.cc ('k') | ash/desktop_background/desktop_background_resources.cc » ('j') | chrome/browser/resources/options2/chromeos/set_wallpaper_options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef ASH_DESKTOP_BACKGROUND_DESKTOP_BACKGROUND_RESOURCES_H_

	6 #define ASH_DESKTOP_BACKGROUND_DESKTOP_BACKGROUND_RESOURCES_H_

	7

	8 class SkBitmap;

	9

	10 namespace ash {

	11

	12 int GetPresetWallpaperIndex();

	13 int GetWallpaperCount();

	14 const SkBitmap& GetDefaultWallpaper(int index);

	15 const SkBitmap& GetDefaultWallpaperThumbnail(int index);
	flackr 2012/03/08 03:31:58 Only thing I might suggest is putting this in an i Only thing I might suggest is putting this in an inner namespace (like ash::backgrounds) to avoid having 4 new names in the ash namespace. I'm not sure if this is common practice though. bshe 2012/03/08 16:36:40 +ben It sounds good to me. But probably leave thi Show quoted text On 2012/03/08 03:31:58, flackr wrote: > Only thing I might suggest is putting this in an inner namespace (like > ash::backgrounds) to avoid having 4 new names in the ash namespace. I'm not sure > if this is common practice though. +ben It sounds good to me. But probably leave this decision to Ben since we are not sure? :)
	16

	17 } // namespace ash

	18

	19 #endif // ASH_DESKTOP_BACKGROUND_DESKTOP_BACKGROUND_RESOURCES_H_

OLD	NEW