Enable user change background image in settings page in Aura build.

ash/shell.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell.h"
 
 #include <algorithm>
 
 #include "ash/app_list/app_list.h"
 #include "ash/ash_switches.h"
+#include "ash/desktop_background/desktop_background_controller.h"
+#include "ash/desktop_background/desktop_background_resources.h"
+#include "ash/desktop_background/desktop_background_view.h"
 #include "ash/drag_drop/drag_drop_controller.h"
 #include "ash/focus_cycler.h"
 #include "ash/ime/input_method_event_filter.h"
 #include "ash/launcher/launcher.h"
 #include "ash/shell_delegate.h"
 #include "ash/shell_factory.h"
 #include "ash/shell_window_ids.h"
 #include "ash/system/audio/tray_volume.h"
 #include "ash/system/brightness/tray_brightness.h"
 #include "ash/system/settings/tray_settings.h"
@@ skipping 446 matching lines @@
 
   window_modality_controller_.reset(new internal::WindowModalityController);
   AddRootWindowEventFilter(window_modality_controller_.get());
 
   visibility_controller_.reset(new internal::VisibilityController);
 
   tooltip_controller_.reset(new internal::TooltipController);
   AddRootWindowEventFilter(tooltip_controller_.get());
 
   drag_drop_controller_.reset(new internal::DragDropController);
+  desktop_background_controller_.reset(new DesktopBackgroundController);
   power_button_controller_.reset(new PowerButtonController);
   video_detector_.reset(new VideoDetector);
   window_cycle_controller_.reset(new WindowCycleController);
 }
 
 Shell::WindowMode Shell::ComputeWindowMode(CommandLine* command_line) const {
   if (compact_window_mode_for_test_)
     return MODE_COMPACT;
 
   // Some devices don't perform well with overlapping windows.
@@ skipping 45 matching lines @@
   if (workspace_controller_.get())
     workspace_controller_->ShowMenu(widget, location);
 }
 
 void Shell::ToggleAppList() {
   if (!app_list_.get())
     app_list_.reset(new internal::AppList);
   app_list_->SetVisible(!app_list_->IsVisible());
 }
 
+void Shell::SetDesktopBackgroundWallpaper(const SkBitmap& wallpaper) {
+  if (desktop_background_mode_ == BACKGROUND_SOLID_COLOR)
+    return;
+  DCHECK(root_window_layout_->background_widget());
+  static_cast<internal::DesktopBackgroundView*>(
+      root_window_layout_->background_widget()->widget_delegate())->
+      SetWallpaper(wallpaper);
+}
+
 void Shell::SetDesktopBackgroundMode(BackgroundMode mode) {

[flackr, 2012/03/06 17:16:49]

I think this function should become SetDesktopBackgroundSolidColor() and
SetDesktopBackgroundWallpaper should change the desktop_background_mode_ if
necessary and set the background. This way if you currently have a solid color
set and select a background it will switch modes and set it. Also from a coding
perspective you can pass the background to set to the DesktopBackgroundView
constructor.

[bshe, 2012/03/06 19:56:16]

Just to confirm, your intention here is to enable the ability to switch between
solid color mode and image mode?

My understanding is that the solid color mode is only used in compact window
mode now. Unless we want to switch from compact mode to managed mode
dynamically, we dont need switch between solid color to image. 

To set a solid color background in managed mode, the current plan is to create
some solid color resources/images and draw them on screen using
DesktopBackgroundView.

I agree for solid color background, we should use the solid color mode for
memory efficiency. Do you want push this into this CL or should I just add a
TODO for now?

[flackr, 2012/03/06 20:25:28]

This is probably important, I think if we start supporting switching background
modes that this will break wallpaper switching (i.e. when you switch to solid
color mode selecting wallpapers won't do anything and when you switch back to
wallpaper mode it won't have a background until you select another wallpaper).
There is an accelerator in accelerator_controller.cc which changes background
modes on ctrl+alt+b if you compile with NDEBUG. You could test to see what
happens. I imagine this is okay as a TODO for now given that switching is not
allowed on release builds.

[bshe, 2012/03/07 19:50:44]

It seems the ToT build can't switch the color mode back and forth. I will create
a bug to track this. At the same time, I have modified my code according to your
suggestion so when user switch color mode, the user selected image will draw. 

   if (mode == BACKGROUND_SOLID_COLOR) {
     // Set a solid black background.
     // TODO(derat): Remove this in favor of having the compositor only clear the
     // viewport when there are regions not covered by a layer:
     // http://crbug.com/113445
     ui::Layer* background_layer = new ui::Layer(ui::Layer::LAYER_SOLID_COLOR);
     background_layer->SetColor(SK_ColorBLACK);
     GetContainer(internal::kShellWindowId_DesktopBackgroundContainer)->
         layer()->Add(background_layer);
     root_window_layout_->SetBackgroundLayer(background_layer);
@@ skipping 121 matching lines @@
 void Shell::ResetLayoutManager(int container_id) {
   GetContainer(container_id)->SetLayoutManager(NULL);
 }
 
 void Shell::DisableWorkspaceGridLayout() {
   if (workspace_controller_.get())
     workspace_controller_->workspace_manager()->set_grid_size(0);
 }
 
 }  // namespace ash