Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 9580003: Rename URLFetcherImpl::Core::TempFileWriter to FileWriter (Closed)

Created:
8 years, 9 months ago by hashimoto
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Rename URLFetcherImpl::Core::TempFileWriter to FileWriter URLFetcher is going to have a new method 'SaveResponseToFile'. FileWriter is going to manage both temporary and ordinary files. BUG=chromium-os:26971 TEST=content_unittests --gtest_filter="URLFetcher*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124846

Patch Set 1 #

Patch Set 2 : Additional format fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -108 lines) Patch
M content/common/net/url_fetcher_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/net/url_fetcher_impl.cc View 1 27 chunks +97 lines, -107 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
This patch is a preparation before adding URLFetcher:: SaveResponseToFile
8 years, 9 months ago (2012-03-02 08:19:08 UTC) #1
willchan no longer on Chromium
http://codereview.chromium.org/9580003/diff/5002/content/common/net/url_fetcher_impl.cc File content/common/net/url_fetcher_impl.cc (right): http://codereview.chromium.org/9580003/diff/5002/content/common/net/url_fetcher_impl.cc#newcode113 content/common/net/url_fetcher_impl.cc:113: void CreateTempFile(); Rename these too?
8 years, 9 months ago (2012-03-02 19:48:22 UTC) #2
hashimoto
http://codereview.chromium.org/9580003/diff/5002/content/common/net/url_fetcher_impl.cc File content/common/net/url_fetcher_impl.cc (right): http://codereview.chromium.org/9580003/diff/5002/content/common/net/url_fetcher_impl.cc#newcode113 content/common/net/url_fetcher_impl.cc:113: void CreateTempFile(); On 2012/03/02 19:48:22, willchan wrote: > Rename ...
8 years, 9 months ago (2012-03-03 02:56:37 UTC) #3
willchan no longer on Chromium
OIC, LGTM On Fri, Mar 2, 2012 at 6:56 PM, <hashimoto@chromium.org> wrote: > > http://codereview.chromium.**org/9580003/diff/5002/content/** ...
8 years, 9 months ago (2012-03-03 03:06:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9580003/5002
8 years, 9 months ago (2012-03-03 03:30:45 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-03 08:51:47 UTC) #6
Change committed as 124846

Powered by Google App Engine
This is Rietveld 408576698