chrome/browser/resources/chromeos/login/login.html - Issue 9579001: css hack n' slash, continued: New styles for buttons and selects.

Side by Side Diff: chrome/browser/resources/chromeos/login/login.html

Issue 9579001: css hack n' slash, continued: New styles for buttons and selects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix print preview Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <title i18n-content="title"></title>	4 <title i18n-content="title"></title>

5 <link rel="stylesheet" href="chrome://resources/css/button.css">	5 <link rel="stylesheet" href="chrome://resources/css/button.css">

6 <link rel="stylesheet" href="chrome://resources/css/dialogs.css"></link>	6 <link rel="stylesheet" href="chrome://resources/css/dialogs.css"></link>

7 <link rel="stylesheet" href="chrome://resources/css/list.css">	7 <link rel="stylesheet" href="chrome://resources/css/list.css">

8 <link rel="stylesheet" href="chrome://resources/css/select.css">
Dan Beam 2012/03/02 17:58:43 I'd move button.css to the old position of select. I'd move button.css to the old position of select.css here and throughout, IMO, as otherwise you might have cascade issues. Evan Stade 2012/03/02 19:46:20 depending on order is inherently a bug imo (except Show quoted text On 2012/03/02 17:58:43, Dan Beam wrote: > I'd move button.css to the old position of select.css here and throughout, IMO, > as otherwise you might have cascade issues. depending on order is inherently a bug imo (except maybe if it's two rules in the same file --- even that is iffy though). I'd rather keep them alphabetical, and if this uncovers a dormant ordering bug, we'll find it and squash it (also, while it exists, it's not likely to be very high impact).
9 <link rel="stylesheet" href="chrome://resources/css/spinner.css">	8 <link rel="stylesheet" href="chrome://resources/css/spinner.css">

10 <link rel="stylesheet" href="bubble.css">	9 <link rel="stylesheet" href="bubble.css">

11 <link rel="stylesheet" href="header_bar.css">	10 <link rel="stylesheet" href="header_bar.css">

12 <link rel="stylesheet" href="network_dropdown.css">	11 <link rel="stylesheet" href="network_dropdown.css">

13 <link rel="stylesheet" href="oobe.css">	12 <link rel="stylesheet" href="oobe.css">

14 <link rel="stylesheet" href="screen_account_picker.css">	13 <link rel="stylesheet" href="screen_account_picker.css">

15 <link rel="stylesheet" href="screen_gaia_signin.css">	14 <link rel="stylesheet" href="screen_gaia_signin.css">

16 <link rel="stylesheet" href="screen_error_message.css">	15 <link rel="stylesheet" href="screen_error_message.css">

17 <link rel="stylesheet" href="user_pod_row.css">	16 <link rel="stylesheet" href="user_pod_row.css">

18 <script src="chrome://resources/js/cr.js"></script>	17 <script src="chrome://resources/js/cr.js"></script>

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 <div id="progress"></div>	61 <div id="progress"></div>

63 <div id="button-strip" class="button-strip"></div>	62 <div id="button-strip" class="button-strip"></div>

64 </div>	63 </div>

65 </div>	64 </div>

66 </div>	65 </div>

67 <div id="bubble" class="bubble faded" hidden></div>	66 <div id="bubble" class="bubble faded" hidden></div>

68 <include src="version.html">	67 <include src="version.html">

69 <include src="user_pod_template.html">	68 <include src="user_pod_template.html">

70 </body>	69 </body>

71 </html>	70 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/login/oobe.html » ('j') | chrome/browser/resources/chromeos/proxy_settings.html » ('J')