Issue 9572038: Convert uses of int ms to TimeDelta in jingle and remoting.

Issue 9572038: Convert uses of int ms to TimeDelta in jingle and remoting. (Closed)

Created:
8 years, 9 months ago by Ted Vessenes

Modified:
8 years, 9 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Convert uses of int ms to TimeDelta in jingle and remoting. R=sergeyu@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124915

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -13 lines)			Patch
M	jingle/glue/pseudotcp_adapter_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/thread_wrapper_unittest.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
M	remoting/client/plugin/chromoting_instance.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/host/policy_hack/nat_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/iq_sender.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/jingle_glue/jingle_thread_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/connection_tester.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM http://codereview.chromium.org/9572038/diff/1/jingle/glue/thread_wrapper_unittest.cc File jingle/glue/thread_wrapper_unittest.cc (right): http://codereview.chromium.org/9572038/diff/1/jingle/glue/thread_wrapper_unittest.cc#newcode152 jingle/glue/thread_wrapper_unittest.cc:152: MessageLoop::QuitClosure(), nit: move this to the previous line. ...

8 years, 9 months ago (2012-03-04 19:54:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9572038/5001

8 years, 9 months ago (2012-03-04 23:41:38 UTC) #3

Change committed as 124915

Expand Messages | Collapse Messages