Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 9572036: Convert uses of int ms to TimeDelta in chrome/browser and net. (Closed)

Created:
8 years, 9 months ago by Ted Vessenes
Modified:
8 years, 9 months ago
CC:
chromium-reviews, MAD, jam, jar (doing other things), erikwright (departed), wtc, cbentzel+watch_chromium.org, Randy Smith (Not in Mondays), darin-cc_chromium.org, rkn, stuartmorgan+watch_chromium.org, Ilya Sherman, mmenke
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert uses of int ms to TimeDelta in chrome/browser and net. R=jar@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124890

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add more TimeDelta integration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/histogram_synchronizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/histogram_synchronizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/tracking_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/sqlite_origin_bound_cert_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/base/cookie_store_unittest.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/base/host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/curvecp/client_packetizer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/curvecp/client_packetizer.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ted Vessenes
8 years, 9 months ago (2012-03-03 05:43:02 UTC) #1
jar (doing other things)
LGTM Also noted two places you might want to go further (maybe in this or ...
8 years, 9 months ago (2012-03-03 22:54:43 UTC) #2
Ted Vessenes
I think those changes are largely justified, so I updated as such.
8 years, 9 months ago (2012-03-04 05:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9572036/5001
8 years, 9 months ago (2012-03-04 05:48:49 UTC) #4
commit-bot: I haz the power
Change committed as 124890
8 years, 9 months ago (2012-03-04 07:18:35 UTC) #5
Ryan Sleevi
8 years, 9 months ago (2012-03-04 07:37:13 UTC) #6
Had to revert this. Looks like those last minute changes were missing some
proper includes.

In file included from net/curvecp/client_packetizer.cc:5:
./net/curvecp/client_packetizer.h:69:error: 'base::TimeDelta' has not been
declared
net/curvecp/client_packetizer.cc: In member function 'int
net::ClientPacketizer::DoWaitingCookie()':
net/curvecp/client_packetizer.cc:239:error: no matching function for call to
'net::ClientPacketizer::StartHelloTimer(base::TimeDelta)'
./net/curvecp/client_packetizer.h:69: note: candidates are: void
net::ClientPacketizer::StartHelloTimer(int)
net/curvecp/client_packetizer.cc: At global scope:
net/curvecp/client_packetizer.cc:317:error: prototype for 'void
net::ClientPacketizer::StartHelloTimer(base::TimeDelta)' does not match any in
class 'net::ClientPacketizer'
./net/curvecp/client_packetizer.h:69:error: candidate is: void
net::ClientPacketizer::StartHelloTimer(int)
make: *** [out/Release/obj.target/curvecp/net/curvecp/client_packetizer.o] Error
1

Powered by Google App Engine
This is Rietveld 408576698