content/browser/appcache/chrome_appcache_service.cc - Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/chrome_appcache_service.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang fix Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate.cc ('K') | « content/browser/appcache/chrome_appcache_service.h ('k') | content/browser/geolocation/network_location_request.cc » ('j') | content/public/common/content_url_request_user_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/chrome_appcache_service.cc

diff --git a/content/browser/appcache/chrome_appcache_service.cc b/content/browser/appcache/chrome_appcache_service.cc

index 6fa5ebc613d5bbb366d3fbbd60578c2b8f9084c5..9db8588df1527521299e7d009d40463b1322fe38 100644

--- a/content/browser/appcache/chrome_appcache_service.cc

+++ b/content/browser/appcache/chrome_appcache_service.cc

@@ -8,7 +8,9 @@

#include "base/file_util.h"

#include "content/public/browser/content_browser_client.h"

#include "content/public/browser/resource_context.h"

+#include "content/public/common/content_url_request_user_data.h"

#include "net/base/net_errors.h"

+#include "net/url_request/url_request.h"

#include "webkit/quota/quota_manager.h"

using content::BrowserThread;

@@ -65,3 +67,10 @@ bool ChromeAppCacheService::CanCreateAppCache(

return content::GetContentClient()->browser()->AllowAppCache(

manifest_url, first_party, resource_context_);

}

+void ChromeAppCacheService::InitializeUpdateRequest(net::URLRequest* request) {

+ // TODO(jochen): Do cookie audit.

+ request->SetUserData(

+ content::ContentURLRequestUserData::kUserDataKey,

+ new content::ContentURLRequestUserData());