chrome/common/net/gaia/gaia_auth_fetcher.cc - Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/gaia/gaia_auth_fetcher.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang fix Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate.cc ('K') | « chrome/browser/web_resource/web_resource_service.cc ('k') | chrome/common/net/gaia/gaia_oauth_client.cc » ('j') | content/public/common/content_url_request_user_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/net/gaia/gaia_auth_fetcher.cc

diff --git a/chrome/common/net/gaia/gaia_auth_fetcher.cc b/chrome/common/net/gaia/gaia_auth_fetcher.cc

index d70ff783df8a97aade008292657a14c4e574b028..acda6a5e6e12516870dd1c0ed0e18e15fff48a17 100644

--- a/chrome/common/net/gaia/gaia_auth_fetcher.cc

+++ b/chrome/common/net/gaia/gaia_auth_fetcher.cc

@@ -18,6 +18,7 @@

#include "chrome/common/net/gaia/gaia_constants.h"

#include "chrome/common/net/gaia/gaia_urls.h"

#include "chrome/common/net/gaia/google_service_auth_error.h"

+#include "content/public/common/content_url_request_user_data.h"

#include "content/public/common/url_fetcher.h"

#include "net/base/escape.h"

#include "net/base/load_flags.h"

@@ -189,6 +190,9 @@ content::URLFetcher* GaiaAuthFetcher::CreateGaiaFetcher(

body == "" ? content::URLFetcher::GET : content::URLFetcher::POST,

delegate);

to_return->SetRequestContext(getter);

+ // TODO(jochen): Do cookie audit.

+ to_return->SetContentURLRequestUserData(

+ new content::ContentURLRequestUserData());

to_return->SetUploadData("application/x-www-form-urlencoded", body);

// The Gaia token exchange requests do not require any cookie-based