chrome/browser/extensions/webstore_install_helper.cc - Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_install_helper.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang fix Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/browser/feedback/feedback_util.cc » ('j') | chrome/browser/net/chrome_network_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_install_helper.cc

diff --git a/chrome/browser/extensions/webstore_install_helper.cc b/chrome/browser/extensions/webstore_install_helper.cc

index d5184ed870a543d054c448e2946f31640d13872d..155f40383445745adf28cb1797c3f91b7ac69b12 100644

--- a/chrome/browser/extensions/webstore_install_helper.cc

+++ b/chrome/browser/extensions/webstore_install_helper.cc

@@ -11,6 +11,7 @@

#include "chrome/common/chrome_utility_messages.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/utility_process_host.h"

+#include "content/public/common/content_url_request_user_data.h"

#include "content/public/common/url_fetcher.h"

#include "net/base/load_flags.h"

#include "net/url_request/url_request_context_getter.h"

@@ -61,6 +62,9 @@ void WebstoreInstallHelper::Start() {

url_fetcher_.reset(content::URLFetcher::Create(

icon_url_, content::URLFetcher::GET, this));

url_fetcher_->SetRequestContext(context_getter_);

+ // TODO(jochen): Do cookie audit.

+ url_fetcher_->SetContentURLRequestUserData(

+ new content::ContentURLRequestUserData());

url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES);

url_fetcher_->Start();