chrome/browser/extensions/apps_promo.cc - Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/apps_promo.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang fix Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/app_notify_channel_setup.cc ('k') | chrome/browser/extensions/extension_updater.cc » ('j') | chrome/browser/net/chrome_network_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/apps_promo.cc

diff --git a/chrome/browser/extensions/apps_promo.cc b/chrome/browser/extensions/apps_promo.cc

index f67999a7ebb41f8e18c4cd4eab7acfa1be9e5c1b..0edd6d14da9212d5084b6f0d2595d9086aaf2b72 100644

--- a/chrome/browser/extensions/apps_promo.cc

+++ b/chrome/browser/extensions/apps_promo.cc

@@ -15,6 +15,7 @@

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/pref_names.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/common/content_url_request_user_data.h"

#include "content/public/common/url_constants.h"

#include "content/public/common/url_fetcher.h"

#include "net/base/load_flags.h"

@@ -360,6 +361,9 @@ void AppsPromoLogoFetcher::FetchLogo() {

0, promo_data_.logo, content::URLFetcher::GET, this));

url_fetcher_->SetRequestContext(

g_browser_process->system_request_context());

+ // No user data, as the request will be cookie-less.

+ url_fetcher_->SetContentURLRequestUserData(

+ new content::ContentURLRequestUserData());

url_fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |

net::LOAD_DO_NOT_SAVE_COOKIES);

url_fetcher_->Start();