Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: net/base/network_delegate.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/network_delegate.h ('k') | net/proxy/network_delegate_error_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_delegate.cc
diff --git a/net/base/network_delegate.cc b/net/base/network_delegate.cc
index 87ecf39eb3076ebbc55134dab882ef3cb5e6f7b6..6b857cf83100a414459101cc3915c189bf712ca2 100644
--- a/net/base/network_delegate.cc
+++ b/net/base/network_delegate.cc
@@ -5,6 +5,8 @@
#include "net/base/network_delegate.h"
#include "base/logging.h"
+#include "net/base/load_flags.h"
+#include "net/url_request/url_request.h"
namespace net {
@@ -90,4 +92,21 @@ NetworkDelegate::AuthRequiredResponse NetworkDelegate::NotifyAuthRequired(
return OnAuthRequired(request, auth_info, callback, credentials);
}
+bool NetworkDelegate::NotifyReadingCookies(
+ const URLRequest* request,
+ const CookieList& cookie_list) {
+ DCHECK(CalledOnValidThread());
+ DCHECK(!(request->load_flags() & net::LOAD_DO_NOT_SEND_COOKIES));
+ return CanGetCookies(request, cookie_list);
+}
+
+bool NetworkDelegate::NotifySettingCookie(
+ const URLRequest* request,
+ const std::string& cookie_line,
+ CookieOptions* options) {
+ DCHECK(CalledOnValidThread());
+ DCHECK(!(request->load_flags() & net::LOAD_DO_NOT_SAVE_COOKIES));
+ return CanSetCookie(request, cookie_line, options);
+}
+
} // namespace net
« no previous file with comments | « net/base/network_delegate.h ('k') | net/proxy/network_delegate_error_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698