Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index 0f26b2c13a2e41d627faa06be4666a27475df179..c44087251645f96e1e5761e2b893e2aeea936eff 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -1435,36 +1435,6 @@ void ResourceDispatcherHost::OnSSLCertificateError(
SSLManager::OnSSLCertificateError(this, request, ssl_info, is_hsts_host);
}
-bool ResourceDispatcherHost::CanGetCookies(
- const net::URLRequest* request,
- const net::CookieList& cookie_list) const {
- VLOG(1) << "OnGetCookies: " << request->url().spec();
- int render_process_id, render_view_id;
- if (!RenderViewForRequest(request, &render_process_id, &render_view_id))
- return false;
-
- const ResourceRequestInfoImpl* info = InfoForRequest(request);
-
- return content::GetContentClient()->browser()->AllowGetCookie(
- request->url(), request->first_party_for_cookies(), cookie_list,
- info->GetContext(), render_process_id, render_view_id);
-}
-
-bool ResourceDispatcherHost::CanSetCookie(const net::URLRequest* request,
- const std::string& cookie_line,
- net::CookieOptions* options) const {
- VLOG(1) << "OnSetCookie: " << request->url().spec();
-
- int render_process_id, render_view_id;
- if (!RenderViewForRequest(request, &render_process_id, &render_view_id))
- return false;
-
- const ResourceRequestInfoImpl* info = InfoForRequest(request);
- return content::GetContentClient()->browser()->AllowSetCookie(
- request->url(), request->first_party_for_cookies(), cookie_line,
- info->GetContext(), render_process_id, render_view_id, options);
-}
-
void ResourceDispatcherHost::OnResponseStarted(net::URLRequest* request) {
VLOG(1) << "OnResponseStarted: " << request->url().spec();
ResourceRequestInfoImpl* info = InfoForRequest(request);
« no previous file with comments | « content/browser/renderer_host/resource_dispatcher_host.h ('k') | content/browser/renderer_host/resource_request_info_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698