chrome/browser/search_engines/template_url_fetcher_unittest.cc - Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_fetcher_unittest.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chromeos Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search_engines/template_url_fetcher.h ('K') | « chrome/browser/search_engines/template_url_fetcher.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.h » ('j') | webkit/appcache/appcache_update_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/template_url_fetcher_unittest.cc

diff --git a/chrome/browser/search_engines/template_url_fetcher_unittest.cc b/chrome/browser/search_engines/template_url_fetcher_unittest.cc

index 1745678f3250b0dee59c9d2a99bd78f25caa48db..362a09a9690687b8431ef4464d1666f6e0400528 100644

--- a/chrome/browser/search_engines/template_url_fetcher_unittest.cc

+++ b/chrome/browser/search_engines/template_url_fetcher_unittest.cc

@@ -147,8 +147,8 @@ void TemplateURLFetcherTest::StartDownload(

GURL osdd_url = test_server_.GetURL("files/" + osdd_file_name);

GURL favicon_url;

test_util_.profile()->GetTemplateURLFetcher()->ScheduleDownload(

- keyword, osdd_url, favicon_url, new TemplateURLFetcherTestCallbacks(this),

- provider_type);

+ keyword, osdd_url, favicon_url, NULL /* web_contents */,

Peter Kasting 2012/03/08 20:46:27 Nit: No need for the /* */ comment since none of t

+ new TemplateURLFetcherTestCallbacks(this), provider_type);

}

void TemplateURLFetcherTest::WaitForDownloadToFinish() {