Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

webkit/appcache/appcache_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 #define WEBKIT_APPCACHE_APPCACHE_SERVICE_H_
 
 #include <map>
 #include <set>
 
@@ skipping 90 matching lines @@
 
   // Context for use during cache updates, should only be accessed
   // on the IO thread. We do NOT add a reference to the request context,
   // it is the callers responsibility to ensure that the pointer
   // remains valid while set.
   net::URLRequestContext* request_context() const { return request_context_; }
   void set_request_context(net::URLRequestContext* context) {
     request_context_ = context;
   }
 
+  // Perform additional initialization steps on an URLRequest used for cache
+  // updates. Should only be accessed on the UI thread.

[michaeln, 2012/03/01 17:47:01]

please define this method on AppCachePolicy instead of on this class, and
include in it's signature an AppCacheUpdateJob* parameter (otherwise there is no
context with which to determine the values you want associated with the
request).

void AppCachePolicy::AddUserDataForUpdateRequest(job, req);

[jochen (gone - plz use gerrit), 2012/03/01 18:41:01]

Ideally, I want to attach the process_id/routing_id at this point. Can I derive
these values from the job somehow?

+  virtual void InitializeUpdateRequest(net::URLRequest* request) {};
+
   // The appcache policy, may be null, in which case access is always allowed.
   // The service does NOT assume ownership of the policy, it is the callers
   // responsibility to ensure that the pointer remains valid while set.
   AppCachePolicy* appcache_policy() const { return appcache_policy_; }
   void set_appcache_policy(AppCachePolicy* policy) {
     appcache_policy_ = policy;
   }
 
   quota::SpecialStoragePolicy* special_storage_policy() const {
     return special_storage_policy_.get();
@@ skipping 59 matching lines @@
   bool clear_local_state_on_exit_;
   // If true, nothing (not even session-only data) should be deleted on exit.
   bool save_session_state_;
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheService);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_SERVICE_H_