Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.

net/base/network_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_DELEGATE_H_
 #define NET_BASE_NETWORK_DELEGATE_H_
 #pragma once
 
+#include <string>
+
 #include "base/callback.h"
 #include "base/string16.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/auth.h"
 #include "net/base/completion_callback.h"
 
 class GURL;
 
 namespace net {
 
 // NOTE: Layering violations!
 // We decided to accept these violations (depending
 // on other net/ submodules from net/base/), because otherwise NetworkDelegate
 // would have to be broken up into too many smaller interfaces targeted to each
 // submodule. Also, since the lower levels in net/ may callback into higher
 // levels, we may encounter dangerous casting issues.
 //
 // NOTE: It is not okay to add any compile-time dependencies on symbols outside
 // of net/base here, because we have a net_base library. Forward declarations
 // are ok.
+class CookieList;
+class CookieOptions;
 class HttpRequestHeaders;
 class HttpResponseHeaders;
 class URLRequest;
 
 class NetworkDelegate : public base::NonThreadSafe {
  public:
   // AuthRequiredResponse indicates how a NetworkDelegate handles an
   // OnAuthRequired call. It's placed in this file to prevent url_request.h
   // from having to include network_delegate.h.
   enum AuthRequiredResponse {
@@ skipping 27 matching lines @@
                             const GURL& new_location);
   void NotifyResponseStarted(URLRequest* request);
   void NotifyRawBytesRead(const URLRequest& request, int bytes_read);
   void NotifyCompleted(URLRequest* request, bool started);
   void NotifyURLRequestDestroyed(URLRequest* request);
   void NotifyPACScriptError(int line_number, const string16& error);
   AuthRequiredResponse NotifyAuthRequired(URLRequest* request,
                                           const AuthChallengeInfo& auth_info,
                                           const AuthCallback& callback,
                                           AuthCredentials* credentials);
+  bool NotifyReadingCookies(const URLRequest* request,
+                            const CookieList& cookie_list);
+  bool NotifySettingCookie(const URLRequest* request,
+                           const std::string& cookie_line,
+                           CookieOptions* options);
 
  private:
   // This is the interface for subclasses of NetworkDelegate to implement. This
   // member functions will be called by the respective public notification
   // member function, which will perform basic sanity checking.
 
   // Called before a request is sent. Allows the delegate to rewrite the URL
   // being fetched by modifying |new_url|. |callback| and |new_url| are valid
   // only until OnURLRequestDestroyed is called for this request. Returns a net
   // status code, generally either OK to continue with the request or
@@ skipping 76 matching lines @@
   //    should not be attempted.
   //  - AUTH_REQUIRED_RESPONSE_IO_PENDING: The action will be decided
   //    asynchronously. |callback| will be invoked when the decision is made,
   //    and one of the other AuthRequiredResponse values will be passed in with
   //    the same semantics as described above.
   virtual AuthRequiredResponse OnAuthRequired(
       URLRequest* request,
       const AuthChallengeInfo& auth_info,
       const AuthCallback& callback,
       AuthCredentials* credentials) = 0;
+
+  // Corresponds to URLRequestDelegate::CanGetCookies

[willchan no longer on Chromium, 2012/03/01 20:30:10]

I think the OnFoo() naming scheme works great for void and int (net::Error)
responses, but not for bool. Please rename to CanGetCookies() and
CanSetCookie().

+  virtual bool OnReadingCookies(const URLRequest* request,
+                                const CookieList& cookie_list) = 0;
+
+  // Corresponds to URLRequestDelegate::CanSetCookie
+  virtual bool OnSettingCookie(const URLRequest* request,
+                               const std::string& cookie_line,
+                               CookieOptions* options) = 0;
+
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_DELEGATE_H_