Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: net/base/network_delegate.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/base/network_delegate.h ('k') | net/proxy/network_delegate_error_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/network_delegate.h" 5 #include "net/base/network_delegate.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/base/load_flags.h"
9 #include "net/url_request/url_request.h"
8 10
9 namespace net { 11 namespace net {
10 12
11 int NetworkDelegate::NotifyBeforeURLRequest( 13 int NetworkDelegate::NotifyBeforeURLRequest(
12 URLRequest* request, const CompletionCallback& callback, 14 URLRequest* request, const CompletionCallback& callback,
13 GURL* new_url) { 15 GURL* new_url) {
14 DCHECK(CalledOnValidThread()); 16 DCHECK(CalledOnValidThread());
15 DCHECK(request); 17 DCHECK(request);
16 DCHECK(!callback.is_null()); 18 DCHECK(!callback.is_null());
17 return OnBeforeURLRequest(request, callback, new_url); 19 return OnBeforeURLRequest(request, callback, new_url);
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 85
84 NetworkDelegate::AuthRequiredResponse NetworkDelegate::NotifyAuthRequired( 86 NetworkDelegate::AuthRequiredResponse NetworkDelegate::NotifyAuthRequired(
85 URLRequest* request, 87 URLRequest* request,
86 const AuthChallengeInfo& auth_info, 88 const AuthChallengeInfo& auth_info,
87 const AuthCallback& callback, 89 const AuthCallback& callback,
88 AuthCredentials* credentials) { 90 AuthCredentials* credentials) {
89 DCHECK(CalledOnValidThread()); 91 DCHECK(CalledOnValidThread());
90 return OnAuthRequired(request, auth_info, callback, credentials); 92 return OnAuthRequired(request, auth_info, callback, credentials);
91 } 93 }
92 94
95 bool NetworkDelegate::NotifyReadingCookies(
96 const URLRequest* request,
97 const CookieList& cookie_list) {
98 DCHECK(CalledOnValidThread());
99 DCHECK(!(request->load_flags() & net::LOAD_DO_NOT_SEND_COOKIES));
100 return CanGetCookies(request, cookie_list);
101 }
102
103 bool NetworkDelegate::NotifySettingCookie(
104 const URLRequest* request,
105 const std::string& cookie_line,
106 CookieOptions* options) {
107 DCHECK(CalledOnValidThread());
108 DCHECK(!(request->load_flags() & net::LOAD_DO_NOT_SAVE_COOKIES));
109 return CanSetCookie(request, cookie_line, options);
110 }
111
93 } // namespace net 112 } // namespace net
OLDNEW
« no previous file with comments | « net/base/network_delegate.h ('k') | net/proxy/network_delegate_error_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698