Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: net/base/network_delegate.cc

Issue 9572001: Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: TestShellNetworkDelegate Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/base/network_delegate.h" 5 #include "net/base/network_delegate.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace net { 9 namespace net {
10 10
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 83
84 NetworkDelegate::AuthRequiredResponse NetworkDelegate::NotifyAuthRequired( 84 NetworkDelegate::AuthRequiredResponse NetworkDelegate::NotifyAuthRequired(
85 URLRequest* request, 85 URLRequest* request,
86 const AuthChallengeInfo& auth_info, 86 const AuthChallengeInfo& auth_info,
87 const AuthCallback& callback, 87 const AuthCallback& callback,
88 AuthCredentials* credentials) { 88 AuthCredentials* credentials) {
89 DCHECK(CalledOnValidThread()); 89 DCHECK(CalledOnValidThread());
90 return OnAuthRequired(request, auth_info, callback, credentials); 90 return OnAuthRequired(request, auth_info, callback, credentials);
91 } 91 }
92 92
93 bool NetworkDelegate::NotifyReadingCookies(
94 const URLRequest* request,
95 const CookieList& cookie_list) {
96 DCHECK(CalledOnValidThread());
willchan no longer on Chromium 2012/03/06 02:59:01 Add DCHECKs like in URLRequest to make sure the ap
jochen (gone - plz use gerrit) 2012/03/08 13:00:02 Done.
97 return CanGetCookies(request, cookie_list);
98 }
99
100 bool NetworkDelegate::NotifySettingCookie(
101 const URLRequest* request,
102 const std::string& cookie_line,
103 CookieOptions* options) {
104 DCHECK(CalledOnValidThread());
105 return CanSetCookie(request, cookie_line, options);
106 }
107
93 } // namespace net 108 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698