chromeos: Turn on ash only when building non-gtk.

chromeos: Turn on ash only when building non-gtk.

BUG=none
TEST=none

[sadrul, 2012-03-04 06:10:36]

Hi! Give this a try. I can build with chromeos_gtk=1 chromeos=1 and it seems to
start up OK.

[Peter Mayo, 2012-03-04 17:52:57]

lgtm

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:5589: ['chromeos_gtk==1', {
Should this test actually be use_ash==0 ?

[Elliot Glaysher, 2012-03-05 18:29:59]

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:5589: ['chromeos_gtk==1', {
On 2012/03/04 17:52:57, Peter Mayo wrote:
> Should this test actually be use_ash==0 ?

use_ash==0 is the majority of builds, no?

[Peter Mayo, 2012-03-05 19:43:34]

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/9570065/diff/3001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:5589: ['chromeos_gtk==1', {
On 2012/03/05 18:30:00, Elliot Glaysher wrote:
> On 2012/03/04 17:52:57, Peter Mayo wrote:
> > Should this test actually be use_ash==0 ?
> 
> use_ash==0 is the majority of builds, no?

Probably -> the exclude still applies.

The include wouldn't, so chromeos_gtk==1 is indeed neater.

[sadrul, 2012-03-05 19:45:26]

+saintlou

Is this something we want/need?

[Emmanuel Saint-loubert-Bié, 2012-03-05 20:17:29]

Well right now the chromeos_gtk => implies chromeos. 

These 2 flags were originally meant to be used in a GYP where you would specify
only one or the other.

Anyway chromeos_gtk should be deprecated soon. So I would prefer to have tests
for use_ash or use_aura (as appropriate).

-- Emmanuel