Issue 9570059: Add support for window size constraints to ShellWindowGtk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9570059: Add support for window size constraints to ShellWindowGtk. (Closed)

Created:
8 years, 9 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 9 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for window size constraints to ShellWindowGtk. R=erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124724

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -4 lines)			Patch
	M	chrome/browser/ui/gtk/extensions/shell_window_gtk.cc	View		1 chunk	+30 lines, -4 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mihai Parparita -not on Chrome

https://chromiumcodereview.appspot.com/9570059/diff/1/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc File chrome/browser/ui/gtk/extensions/shell_window_gtk.cc (right): https://chromiumcodereview.appspot.com/9570059/diff/1/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc#newcode36 chrome/browser/ui/gtk/extensions/shell_window_gtk.cc:36: hints.max_height = max_height ? max_height : G_MAXINT; Per http://developer.gnome.org/gdk/stable/gdk-Windows.html#GdkGeometry ...

8 years, 9 months ago (2012-03-02 02:01:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/9570059/1

8 years, 9 months ago (2012-03-02 18:02:55 UTC) #4

Change committed as 124724

Expand Messages | Collapse Messages