Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/options2/browser_options.js

Issue 9570053: [uber page] Fix ignored first click on 'show advanced settings'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/browser_options.js
===================================================================
--- chrome/browser/resources/options2/browser_options.js (revision 124536)
+++ chrome/browser/resources/options2/browser_options.js (working copy)
@@ -459,7 +459,7 @@
* @private
*/
toggleAdvancedSettings_: function() {
- if ($('advanced-settings').style.height == '0px')
+ if ($('advanced-settings').style.height == '')
this.showAdvancedSettings_();
else
this.hideAdvancedSettings_();
@@ -481,7 +481,7 @@
* @private
*/
hideAdvancedSettings_: function() {
- $('advanced-settings').style.height = '0px';
+ $('advanced-settings').style.height = '';
$('advanced-settings-expander').innerHTML =
Evan Stade 2012/03/02 17:09:27 should this be textContent?
csilv 2012/03/02 19:29:41 Done.
localStrings.getString('showAdvancedSettings');
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698