[uber page] Fix ignored first click on 'show advanced settings'.

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 441 matching lines @@
     handleWindowMessage_: function(e) {
       if (e.data.method == 'frameSelected')
         $('search-field').focus();
     },
 
     /**
      * Toggle the visibility state of the Advanced section.
      * @private
      */
     toggleAdvancedSettings_: function() {
-      if ($('advanced-settings').style.height == '0px')
+      if ($('advanced-settings').style.height == '')
         this.showAdvancedSettings_();
       else
         this.hideAdvancedSettings_();
     },
 
     /**
      * Show advanced settings.
      * @private
      */
     showAdvancedSettings_: function() {
       $('advanced-settings').style.height =
           $('advanced-settings-container').offsetHeight + 20 + 'px';
       $('advanced-settings-expander').innerHTML =

[Evan Stade, 2012/03/02 17:09:27]

should this be textContent?

[csilv, 2012/03/02 19:29:41]

Done.

           localStrings.getString('hideAdvancedSettings');
     },
 
     /**
      * Hide advanced settings.
      * @private
      */
     hideAdvancedSettings_: function() {
-      $('advanced-settings').style.height = '0px';
+      $('advanced-settings').style.height = '';
       $('advanced-settings-expander').innerHTML =

[Evan Stade, 2012/03/02 17:09:27]

should this be textContent?

[csilv, 2012/03/02 19:29:41]

Done.

           localStrings.getString('showAdvancedSettings');
     },
 
     /**
      * Initializes a button for controlling screen brightness.
      * @param {string} id Button ID.
      * @param {string} callback Name of the callback function.
      */
     initBrightnessButton_: function(id, callback) {
       var button = $(id);
@@ skipping 723 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });